[Asterisk-code-review] res pjsip pubsub: Add more locking and checking around termi... (asterisk[13])

George Joseph asteriskteam at digium.com
Mon Jun 13 13:41:09 CDT 2016


George Joseph has posted comments on this change.

Change subject: res_pjsip_pubsub: Add more locking and checking around terminates
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/3018/2/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 2332: 	if (sub->tree->last_notify) {
> Yes problem.  It is a maintenance issue.  When is it used the original way 
It's always used the new way.  The only place it was ever used was in the scope of this patch.


-- 
To view, visit https://gerrit.asterisk.org/3018
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I779d11802cf672a51392e62a74a1216596075ba1
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-code-review mailing list