[Asterisk-code-review] res pjsip pubsub: Add more locking and checking around termi... (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change.

Change subject: res_pjsip_pubsub: Add more locking and checking around terminates
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/3018/2/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

Line 2332: 	if (sub->tree->last_notify) {
> Yep. Problem?
Yes problem.  It is a maintenance issue.  When is it used the original way and when is it used the new way?  Also, I'm not sure that all the places that reference it won't ever interfere with each other.


Line 3455: 	if (!(sub_tree->evsub && sub_tree->dlg)) {
> I said it was overkill.  I'll remove them if you want.
It sort of indicates that you don't think you have a valid object ref.


-- 
To view, visit https://gerrit.asterisk.org/3018
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I779d11802cf672a51392e62a74a1216596075ba1
Gerrit-PatchSet: 2
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes