[Asterisk-code-review] Restrict CLI/AMI commands on shutdown. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change.

Change subject: Restrict CLI/AMI commands on shutdown.
......................................................................


Patch Set 1:

(1 comment)

Note: I'm not sold on the idea that preventing CLI/AMI during shutdown is the right fix.  Can you open a JIRA ticket to post some backtraces (showing all threads)?

https://gerrit.asterisk.org/#/c/2283/1/main/cli.c
File main/cli.c:

Line 2702
> I see where you're coming from, but I don't think this will actually help. 
I'd prefer keeping the increment inside the lock so we can fix __ast_cli_unregister to check e->inuse with the list locked.

The decrement of e->inuse is safe without locking the list.  Think of this like ao2_find followed by ao2_cleanup.  ao2_find locks the container but ao2_cleanup does not.

I agree that switching to astobj2 would be nice but is outside the scope of this fix plus it can't be done in 11 or 13.


-- 
To view, visit https://gerrit.asterisk.org/2283
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f5b8e665bd4d0108014a8b6589729ecd3677eef
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes