[Asterisk-code-review] Restrict CLI/AMI commands on shutdown. (asterisk[13])

[Mark Michelson]

Mark Michelson has posted comments on this change.

Change subject: Restrict CLI/AMI commands on shutdown.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.asterisk.org/#/c/2283/1/include/asterisk/cli.h
File include/asterisk/cli.h:

Line 190: 	int allow_on_shutdown;
> This breaks ABI compatibility on released branches.
What's the common method for dealing with something like this?


https://gerrit.asterisk.org/#/c/2283/1/main/manager.c
File main/manager.c:

Line 6119: 		ast_log(LOG_ERROR, "Unable to process manager action '%s'. Asterisk is shutting down.\n", action);
> Does this really need to be an error?
I disagree. If we went ahead and executed the AMI action, I might agree that something less severe was warranted. However, the AMI action has been stopped from executing, and it was an error on the part of the user to attempt to execute an AMI command during shutdown.


-- 
To view, visit https://gerrit.asterisk.org/2283
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f5b8e665bd4d0108014a8b6589729ecd3677eef
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <george.joseph at fairview5.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-HasComments: Yes