[Asterisk-code-review] sip to pjsip: Map externhost/ip to Transports. (asterisk[13])

[Alexander Traud]

Alexander Traud has posted comments on this change.

Change subject: sip_to_pjsip: Map externhost/ip to Transports.
......................................................................


Patch Set 1:

Such a change is out of the scope of this change here.

Anyway, I looked at reload_config(.) in chan_sip and do not have the resources to verify your mapping statement. Or stated differently: At the first glance, I was not able to find the place in code, which indicates that one can bound such parameters not just to General but to Peers as well (in chan_sip). Or stated differently: I cannot judge whether a sip.conf exists on this world which has externhost, externip, or externaddr within a Peer section (and what it does). My sip.conf does not have this. This change is about parsing my personal sip.conf correctly.

Therefore, I cannot add that change to this change here, because I would give it a +1 indirectly; which I cannot judge on. Because this is an independent change, please, create your own – alternatively take over this change here, so you get a review of your proposed change. However, because those two changes are independent, I am not aware of a reason for the latter.

If I should re-write the commit message to avoid any misunderstandings (and differentiate between those two changes), please say so.

-- 
To view, visit https://gerrit.asterisk.org/3621
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c5873386cfc388899fa9cf2368639dd12f1b8e4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: No