[Asterisk-code-review] sip to pjsip: Map externhost/ip to Transports. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change.

Change subject: sip_to_pjsip: Map externhost/ip to Transports.
......................................................................


Patch Set 1:

> Currently, an *external*_media_address parameter is written to
 > Endpoints. PJProject rejects the whole Endpoint because of that.
 > Such a parameter belongs into the Transports.
 > 
 > If you like to see 'media_address' written to Endpoints, please,
 > create a new patch/issue/review. I cannot add this to this change
 > here because I do not know what to map from sip.conf. Or stated
 > differently: I cannot answer your question. This was not the
 > objective of the change here. If the commit message is confusing,
 > please say so. In that case, I update it.

Sorry, let me be clearer...  If externip/host appears in the "general" section of sip.conf, then it should be written to external_media_address on transport.  If it's in a peer section of sip.conf however, it should be written to media_address on the endpoint.

-- 
To view, visit https://gerrit.asterisk.org/3621
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c5873386cfc388899fa9cf2368639dd12f1b8e4
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Anonymous Coward #1000019
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-HasComments: No