[asterisk-users] Possible bug in app_meetme.c

Richard Kenner kenner at gnat.com
Sat Oct 17 13:26:47 CDT 2009


Is this patch correct?  The "&&" doesn't make logical sense to me.  I think
it should be "||" and making this change fixes the problem I have with SIP
phones in MeetMe conferences.  If it's correct, is there someplace more
formal that I should submit it to?

*** app_meetme.c.old    2009-10-11 17:56:44.000000000 -0400
--- app_meetme.c        2009-10-17 14:22:29.000000000 -0400
***************
*** 2901,2905 ****
                                                   to write out all the samples.
                                                 */
!                                               if (user->talking && !(confflags & CONFFLAG_OPTIMIZETALKER)) {
                                                        careful_write(fd, f->data.ptr, f->datalen, 0);
                                                }
--- 2901,2905 ----
                                                   to write out all the samples.
                                                 */
!                                               if (user->talking || !(confflags & CONFFLAG_OPTIMIZETALKER)) {
                                                        careful_write(fd, f->data.ptr, f->datalen, 0);
                                                }




More information about the asterisk-users mailing list