[asterisk-dev] ASTERISK-30184 re-INVITE after answering results in wrong stream direction

Joshua C. Colp jcolp at sangoma.com
Wed Sep 7 07:02:40 CDT 2022


On Wed, Sep 7, 2022 at 8:56 AM Fridrich Maximilian <M.Fridrich at commend.com>
wrote:

> I have a potential fix that consists of two relatively separate changes,
> one of
> them modifies channel.c:ast_channel_request_stream_topology_change() and
> the
> other modififies res_pjsip_session.c:resolve_refresh_media_states() (both
> very
> small in size).
>
> Since one of them touches the core and both probably require some
> discussion,
> would you prefer it if I openend separate reviews on Gerrit for them? Only
> in
> concert they fix ASTERISK-30184 but I am unsure of some unintended
> consequences
> since they're relatively major changes of the logic.
>

If they're fixing the same thing, then the same review is best in case it
is ultimately merged and needs to be reverted.

-- 
Joshua C. Colp
Asterisk Project Lead
Sangoma Technologies
Check us out at www.sangoma.com and www.asterisk.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20220907/8e2ead82/attachment.html>


More information about the asterisk-dev mailing list