[asterisk-dev] Submitting of patches

[Joshua C. Colp]

On Tue, Apr 19, 2022 at 7:41 PM Michal Rybarik <michal at rybarik.sk> wrote:

> Hello folks,
>
> I'd like to submit some of my Asterisk patches (which might be useful
> for other users) to the master source tree, and I'd like to do it most
> efficient way (time is short). I have read info about submitting on Wiki
> and I'd like to ask:
>
> - Is it OK to submit following patches to Asterisk?
> - Which is the oldest branch that these patches can be submitted to?
> - For every patch, should I open JIRA issue and then submit patch to
> Gerrit?
>

Current supported branches are 16, 18, 19, and master. A JIRA issue per
change is desired, along with submitting to Gerrit.


>
> Proposed patches:
>
> 1/ Patch to CDR_PROP and CDR engine, which allows to mark last CDR level
> (from the last Dial) as disabled, so it won't be written to the CDR
> storage. It allows to restore similar CDR behaviour as before Asterisk
> 12, when only one CDR was stored for one call from A-party, regardless
> of how many subsequent Dial()s has been made to reach B-party. With
> Asterisk 12 and above and this patch, after unsuccessfull Dial() attempt
> to B-party is made, CDR_PROP(disable_last)=1 can be used to disable
> (discard) last CDR before another Dial() attempt is made.
> This patch also adds displaying of CDR flags to listing of CDRs (core
> show channel ...) to help debug CDR issues.
>

As long as it is optional then it is fine.


>
> 2/ Patch to security events and chan_sip which adds "useragent" field to
> ARI security events and to chan_sip events (Register, Unregister, Failed
> authentication, etc). We found this very useful in several cases - for
> example when SIP user authentication fails, AMI event contains useragent
> field which can be used to check if attempt was from regular phone or
> some SIP scanner.
>
> 3/ Patch to chan_sip which improves processing of incoming UPDATE (RFC
> 3311) to allow interoperability with some IMS/SBC implementations. Basic
> handling of UPDATE of RPID/PAI headers, SDP attachment and
> session-timers is supported. Feature must be enabled in sip.conf
> (allowupdate=yes).
>
> 4/ Patch to chan_sip which adds basic support for P-Early-Media header
> (RFC 5009) and enables early-media interoperability with IMS.
>

The chan_sip module is deprecated and will be removed. Except for bug
fixes, at this point I'm not personally willing to accept new features or
changes like this because of the potential impact on the current state of
chan_sip and high risk of breaking something unintentionally. Things like
this should strictly be done with PJSIP instead.

-- 
Joshua C. Colp
Asterisk Technical Lead
Sangoma Technologies
Check us out at www.sangoma.com and www.asterisk.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20220420/c6753533/attachment-0001.html>