[asterisk-dev] Can someone please review something

[Corey Farrell]

 From your configure.ac:
 > AST_EXT_LIB_CHECK([REDIS], [redis], [redisReaderCreate], 
[hiredis/hiredis.h])

This tries linking with '-lredis', but it needs to use '-lhiredis':

AST_EXT_LIB_CHECK([REDIS], [hiredis], [redisReaderCreate], 
[hiredis/hiredis.h])

In addition instead of using variable prefix "REDIS" (the first 
argument) I suggest switching to "HIREDIS" (don't forget makeopts.in and 
build_tools/menuselect-deps.in).  There are multiple C redis libraries 
so you want the variable name to identify which one you are using.  This 
will also make it match "<depend>hiredis</depend>" in cdr_redis.c so 
menuselect will enable the module.

Since redis is in-memory I'm not really sure about using it for CDR?  I 
could see res_sorcery_redis being useful assuming it could be used as an 
alternative to res_sorcery_astdb or res_sorcery_memory.


On 11/22/2017 06:01 PM, Nir Simionovich wrote:
> Hi All,
>
>   I've started a new branch at team/nirs/cdr-redis-support
>
>   I'm having some issues integrating the hiredis library into the 
> automake. It seems to be configured correctly,
> however, for some odd reason it will not become available in the 
> 'menuselect' tool.
>
>   Would highly appreciate it if someone can take a look for a minute 
> and see if I missed anything major in there.
>
>
> -- 
>
> Kind Regards,
>
>   Nir Simionovich
>
> GreenfieldTech
>
> (schedule) http://nirsimionovich.appointy.com/
>
>   (w)http://www.greenfieldtech.net <http://www.greenfieldtech.net/>
>
>   (p) +972-73-2557799 (MSN):nirs at greenfieldtech.net 
> <mailto:nirs at greenfieldtech.net>
>
>   (m) +972-54-6982826 (GTALK):nir.simionovich at gmail.com 
> <mailto:nir.simionovich at gmail.com>
>
>   (f) +972-73-2557202 (SKYPE): greenfieldtech.nir
>
>
> ----------------------------------------------------------
>
> Zero Your Inbox <https://mailstrom.co/referral/ARZJE> | Cloud Servers 
> <https://www.digitalocean.com/?refcode=97eeea09917a>
>
> ----------------------------------------------------------
>
>
> *Disclaimer:*
>
> This e-mail is intended solely for the person to whom it is addressed 
> and may contain confidential or legally privileged information. Access 
> to this e-mail by anyone else is unauthorized. If an addressing or 
> transmission error has misdirected this e-mail, please notify the 
> author by replying to this e-mail and destroy this e-mail and any 
> attachments.
> E-mail may be susceptible to data corruption, interception, 
> unauthorized amendment, viruses and delays or the consequences 
> thereof. If you are not the intended recipient, be advised that you 
> have received this email in error and that any use, dissemination, 
> forwarding, printing or copying of this email is strictly prohibited.
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20171122/2ac95dd8/attachment.html>