[asterisk-dev] Asterisk now available with bundled pjproject!

[George Joseph]

On Mon, Mar 7, 2016 at 3:37 PM, Marek Červenka <cervajs at fpf.slu.cz> wrote:

> - what pjproject version is base for pjproject-bundled ?
>

​2.4.5,  You can view the version in ./third-party/​version.mak


> - can i somehow list patches in pjproject-bundled ?
>

​The patches are in ./third-party/pjproject/patches as individual patch
files.​


> - can you include this patch ?
> http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2015-September/018607.html
> https://issues.asterisk.org/jira/browse/ASTERISK-24602
>

​We're trying not to diverge from pjproject.  For a patch to be included in
the bundled version, it would either have to be accepted by the pjproject
team, or be rejected by the pjproject team but have enough documented
justification​ that the Asterisk dev team would agree that it makes sense
to diverge.  Since we haven't done this before, it's hard to say what
"enough justification" actually is but I would say that the bar would be
pretty high.

Now if Asterisk crashes and we've identified the issue to be in pjproject
but pjproject refuses to accept a patch (extraordinarily unlikely), that'd
be a yes.  If it's something you'd just like, then no.  Anything in between
is up for discussion.

So my advice would be...

a) Get your patch accepted by pjproject and open a Jira issue with the
pjproject commit.

b) Simply add your patch to the ./third-party/pjproject/patches locally.
It'll be picked up automatically and applied.  It has to apply with 'patch
-p1'.

c) Open a Jira issue and submit a justification to the asterisk-dev mailing
list for discussion.  Or if you've signed a Contributor Agreement and have
Gerrit commit access, you can create a review that adds the patch.  Be
prepared for lively discussion wither way. :)


>
>
> Dne 7.3.2016 v 20:28 George Joseph napsal(a):
>
> The current Asterisk 13 and master git branches have a new feature that
> will be included in 13.8.0:  The ability to compile and run Asterisk with a
> bundled version of pjproject.
> ​​
>
> Why would you want to do this?  Several reasons:
>
>    - Predictability:  When built with the
>    ​bundled
>     pjproject, you're always certain of the version you're running
>    against, no matter where it's installed.
>    - Scalability:  The default pjproject configuration is optimized for
>    client applications. The bundled version's configuration is optimized for
>    server use.
>    - Usability:  Several feature patches, which have been submitted
>    upstream to pjproject but not yet released, have been included in the
>    bundled version.
>    - Safety:  If a security or critical issue is identified in pjproject,
>    it can be patched and made available with a new release of Asterisk instead
>    of
>    ​having to ​
>    waiting for a new release of pjproject
>    ​​
>    .
>    - Maintainability:  You don't need to build and install separate
>    packages.
>    - Supportability:  When asking others for help, there's no question
>    about which version of pjproject you're using and what options it was
>    compiled with.
>    - Compatibility:  This is especially important from a development
>    perspective because it means we can be sure that new pjproject APIs that
>    have been introduced
>    ​,​
>    or old ones that have been deprecated
>    ​,​
>    are handled and tested appropriately in Asterisk.
>    - Reliability:  You can be sure that Asterisk was tested against the
>    bundled version.
>
>
> So now that you're sold, here's how you use it:
>
> All you have to do is add the "--with-pjproject-bundled" option to your
> ./configure command line and remove any other "--with-pjproject" option you
> may have specified.  The configure and make processes will download the
> correct version of pjproject, patch it, configure it, build it and finally
> link Asterisk to it statically.  No changes in runtime configuration are
> required.
>
> Still not sold?  The default behavior hasn't changed so as long as you
> haven't specified "--with-pjproject-bundled", your build and deploy process
> remains as is.
>
> PLEASE TRY THIS!!  I'd love some feedback BEFORE 13.8.0 is released.
>
>
>
>
>
> --
> ---------------------------------------
> Marek Cervenka
> =======================================
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20160307/b4e8adeb/attachment.html>