<div dir="ltr"><div class="gmail_default" style="font-family:arial narrow,sans-serif"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 7, 2016 at 3:37 PM, Marek Červenka <span dir="ltr"><<a href="mailto:cervajs@fpf.slu.cz" target="_blank">cervajs@fpf.slu.cz</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div>- what pjproject version is base for
pjproject-bundled ?<br></div></div></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">2.4.5, You can view the version in ./third-party/version.mak</div></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><div>
- can i somehow list patches in pjproject-bundled ?<br></div></div></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">The patches are in ./third-party/pjproject/patches as individual patch files.</div></div><div> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><div>
- can you include this patch ?
<a href="http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2015-September/018607.html" target="_blank">http://lists.pjsip.org/pipermail/pjsip_lists.pjsip.org/2015-September/018607.html</a>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24602" target="_blank">https://issues.asterisk.org/jira/browse/ASTERISK-24602</a></div></div></blockquote><div><br></div><div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">We're trying not to diverge from pjproject. For a patch to be included in the bundled version, it would either have to be accepted by the pjproject team, or be rejected by the pjproject team but have enough documented justification that the Asterisk dev team would agree that it makes sense to diverge. Since we haven't done this before, it's hard to say what "enough justification" actually is but I would say that the bar would be pretty high.</div><div class="gmail_default" style="font-family:'arial narrow',sans-serif"><br></div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">Now if Asterisk crashes and we've identified the issue to be in pjproject but pjproject refuses to accept a patch (extraordinarily unlikely), that'd be a yes. If it's something you'd just like, then no. Anything in between is up for discussion.</div><div class="gmail_default" style="font-family:'arial narrow',sans-serif"><br></div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">So my advice would be...</div><div class="gmail_default" style="font-family:'arial narrow',sans-serif"><br></div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">a) Get your patch accepted by pjproject and open a Jira issue with the pjproject commit.</div><div class="gmail_default" style="font-family:'arial narrow',sans-serif"><br></div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">b) Simply add your patch to the ./third-party/pjproject/patches locally. It'll be picked up automatically and applied. It has to apply with 'patch -p1'.</div><div class="gmail_default" style="font-family:'arial narrow',sans-serif"><br></div><div class="gmail_default" style="font-family:'arial narrow',sans-serif">c) Open a Jira issue and submit a justification to the asterisk-dev mailing list for discussion. Or if you've signed a Contributor Agreement and have Gerrit commit access, you can create a review that adds the patch. Be prepared for lively discussion wither way. :)</div><div class="gmail_default" style="font-family:'arial narrow',sans-serif"> <span style="font-family:arial,sans-serif"> </span></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF"><div><br>
<br>
Dne 7.3.2016 v 20:28 George Joseph napsal(a):<br>
</div><div><div class="h5">
<blockquote type="cite">
<div dir="ltr">The current Asterisk 13 and master git branches
have a new feature that will be included in 13.8.0: The ability
to compile and run Asterisk with a bundled version of pjproject.<br>
<div></div>
<br>
Why would you want to do this? Several reasons:<br>
<ul>
<li><font face="arial, helvetica, sans-serif">Predictability:
When built with the
<div style="display:inline">bundled</div>
pjproject, you're always certain of the version you're
running against, no matter where it's installed.<br>
</font></li>
<li><font face="arial, helvetica, sans-serif">Scalability:
The default pjproject configuration is optimized for
client applications. The bundled version's configuration
is optimized for server use.<br>
</font></li>
<li><font face="arial, helvetica, sans-serif">Usability:
Several feature patches, which have been submitted
upstream to pjproject but not yet released, have been
included in the bundled version.<br>
</font></li>
<li><font face="arial, helvetica, sans-serif">Safety: If a
security or critical issue is identified in pjproject, it
can be patched and made available with a new release of
Asterisk instead of
<div style="display:inline">having
to </div>
waiting for a new release of pjproject
<div></div>
.</font></li>
<li><font face="arial, helvetica, sans-serif">Maintainability:
You don't need to build and install separate packages.<br>
</font></li>
<li><font face="arial, helvetica, sans-serif">Supportability:
When asking others for help, there's no question about
which version of pjproject you're using and what options
it was compiled with.<br>
</font></li>
<li><font face="arial, helvetica, sans-serif">Compatibility:
This is especially important from a development
perspective because it means we can be sure that new
pjproject APIs that have been introduced
<div style="display:inline">,</div>
or old ones that have been deprecated
<div style="display:inline">,</div>
are handled and tested appropriately in Asterisk.<br>
</font></li>
<li><font face="arial, helvetica, sans-serif">Reliability:
You can be sure that Asterisk was tested against the
bundled version.<br>
</font></li>
</ul>
<br>
So now that you're sold, here's how you use it:<br>
<br>
All you have to do is add the "--with-pjproject-bundled" option
to your ./configure command line and remove any other
"--with-pjproject" option you may have specified. The configure
and make processes will download the correct version of
pjproject, patch it, configure it, build it and finally link
Asterisk to it statically. No changes in runtime configuration
are required.<br>
<br>
Still not sold? The default behavior hasn't changed so as long
as you haven't specified "--with-pjproject-bundled", your build
and deploy process remains as is.<br>
<br>
PLEASE TRY THIS!! I'd love some feedback BEFORE 13.8.0 is
released.
<div><br>
</div>
</div>
<br>
<fieldset></fieldset>
<br>
</blockquote>
<br>
<br>
</div></div><span class="HOEnZb"><font color="#888888"><pre cols="72">--
---------------------------------------
Marek Cervenka
=======================================
</pre>
</font></span></div>
<br>--<br>
_____________________________________________________________________<br>
-- Bandwidth and Colocation Provided by <a href="http://www.api-digital.com" rel="noreferrer" target="_blank">http://www.api-digital.com</a> --<br>
<br>
asterisk-dev mailing list<br>
To UNSUBSCRIBE or update options visit:<br>
<a href="http://lists.digium.com/mailman/listinfo/asterisk-dev" rel="noreferrer" target="_blank">http://lists.digium.com/mailman/listinfo/asterisk-dev</a><br></blockquote></div><br></div></div>