[asterisk-dev] Asterisk goes Spatial Conferencing: the STEAK project

Tue Aug 23 02:41:03 CDT 2016

Hey,

we adjusted the patch set (fftw3 is now a ifdef-ed).
Precisely, these two commits have been modified (basically adding HAVE_FFTW3)

https://gerrit.asterisk.org/#/c/3522/
https://gerrit.asterisk.org/#/c/3524/

Two questions:
1. It seems that we were working outside the commit tree by adjusting
3522 and 3524 - we pulled each one down using _git review -d XXXX_,
applied the modifications, and submitted using _git review_
Is it necessary to also "re-commit" the subsequent patches (or does
gerrit this automatically)?
And if so, how?
At the moment Gerrit does not try to rebuild the subsequent patches
(i.e., 3523 and 3525).

2. How can we withdraw the OPUS patch from the patch set?
https://gerrit.asterisk.org/#/c/3526/

Best,
Dennis
---
Dennis Guse
---
Dennis Guse

On Tue, Aug 16, 2016 at 11:41 AM, Dennis Guse
<dennis.guse at alumni.tu-berlin.de> wrote:
> Hello,
>
> the cleanup and splitting up into individual patches took some time,
> but those are now submitted: Asterisk-26292 [1].
> The issue with this patch set is that it _requires_ libfftw3.
> We just figured out, how the dependency system works and will adjust
> the fftw-related patch by using appropriate #ifdefs defined by the
> xml-based dependency configuration system.
>
> Two questions came up.
> First, how is the submission procedure to Gerrit for _changed_ commits
> and resubmission?
> We submitted the patch set as branch ASTERISK-26292 to Gerrit
> referencing the bug report.
> To keep this, we, we would now need either to delete the branch (how?)
> or create a new branch (ASTERISK-26292-v2)?
> What is the preferred option?
>
> Second, we would like to package OPUS as a library (ie., codec_opus.so).
> Is it sufficient to include all c-files that we included into Asterisk
> and compile it as shared library, so it can be added to Asterisk
> without linking it during build time?
> Are there any known pitfalls or is this straight forward?
> And in which folders does Asterisk search for codec modules?
>
> Best,
> Dennis
>
> [1] https://issues.asterisk.org/jira/browse/ASTERISK-26292
> ---
> Dennis Guse
>
>
> On Fri, Aug 5, 2016 at 5:19 PM, Matthew Jordan <mjordan at digium.com> wrote:
>> Hi Dennis:
>>
>> Apologies for not responding quicker to your e-mail - I've been on
>> vacation the last week and a half. Some comments inline below.
>>
>> On Sat, Jul 23, 2016 at 3:50 AM, Dennis Guse
>> <dennis.guse at alumni.tu-berlin.de> wrote:
>>> Then lets get started.
>>> Due to the relatively large number of changes, we will split them up
>>> into individual patches:
>>
>> Individual patches are great! Smaller changes are always easier to review.
>>
>>> 1) Support for interleaved stereo (mainly softmix and struct channel)
>>> 2) Extension of confbridge with binaural synthesis via convolution (if
>>> channel supports stereo)
>>>
>>> For the patches, we will remove the hard dependency to OPUS (although
>>> we will stick to using it) and also enable L16 with stereo.
>>>
>>> Nevertheless, there are still some open questions:
>>>
>>> 1. Storage and description of HRTFs
>>> Impulse responses are at the moment compiled into Asterisk as a header file.
>>> This header file is generated using a custom C-program converting a
>>> multi-channel wave file into a float-array - hrirs_fabian.wav was
>>> taken from the SoundScapeRenderer
>>> https://github.com/SoundScapeRenderer/ssr/tree/master/data/impulse_responses/hrirs
>>>
>>> For positioning a sound source, the HRTFs for the left and for the
>>> right ear need to be selected according to the desired angle.
>>> This information is at the moment hard-coded as we use a 720-channel
>>> wave (interleaved: left, right) to cover 360 degrees completely.
>>>
>>> Would you prefer to compile the HRTFs into Asterisk (incl. the
>>> hard-coded description) or rather make this configurable?
>>> For the second option, we would need some support in terms of how to
>>> add configuration options.
>>
>> For an initial implementation, I would recommend hard-coding it. If a
>> different data set is needed for different listeners, that would be an
>> improvement that someone could make at a latter time.
>>
>>> 2. Configuration of positioning of conference participants
>>> The positioning of individual participants is at the moment hard-coded
>>> (compiled via header-file).
>>> This is basically an array containing the angles at which participant
>>> _n_ is going to be seated.
>>> This could also be made configurable via configuration file.
>>>
>>> Furthermore, all participants of a conference receive the _same_
>>> acoustical environment (i.e., participant 1 always sits in front of
>>> the listener etc.).
>>> This  limits the computational requirements while individual listeners
>>> cannot configure their desired seating order.
>>> In fact, the own signal of a participant is subtracted after rendering
>>> the whole environment before sending the signals back.
>>
>> Again, I would punt on making this configurable. If the default
>> experience is "good enough", effort put into making this configurable
>> will be wasted. If it is not "good enough", then effort could be
>> expended into making it configurable.
>>
>>> 3. Internal sampling rate of Confbridge
>>> The binaural synthesis is at the moment conducted at 48kHz.
>>> This is actually due to our use of OPUS, which always uses 48kHz for
>>> the decoded signals.
>>> Is this ok?
>>
>> I'm not sure I have a good answer to this. I think it depends on what
>> the experience is like if a lower sampling rate is used. What happens
>> if the sampling rate used in the conference is 8kHz or 16kHz?
>>
>>> 4. Is the dependency to libfftw3 an issue?
>>
>> libfftw3 if GPLv2, so no, it should not be an issue.
>>
>> https://github.com/FFTW/fftw3/blob/master/COPYING
>>
>> That being said, it should not be a hard dependency. If libfftw3 is
>> not installed, the feature should simply not be available.
>>
>> --
>> Matthew Jordan
>> Digium, Inc. | CTO
>> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
>> Check us out at: http://digium.com & http://asterisk.org
>>
>> --
>> _____________________________________________________________________
>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>
>> asterisk-dev mailing list
>> To UNSUBSCRIBE or update options visit:
>>    http://lists.digium.com/mailman/listinfo/asterisk-dev