[asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

[Diederik de Groot]

> On March 27, 2015, 6:14 p.m., rmudgett wrote:
> > I'm wondering if -Wself-assign should not be enabled.  It appears to be just a nuisance warning.

I do agree, some of the clang warnings can be a little bit petty to be honest. Some of them have proven to be quite usefull though. I will leave this up to you guys to decide. I already had to suppress the "-Wunused-command-line-argument" which was annoying me quite a bit, when compiling with --dev-mode :-)


> On March 27, 2015, 6:14 p.m., rmudgett wrote:
> > /branches/13/formats/format_wav.c, lines 114-115
> > <https://reviewboard.asterisk.org/r/4544/diff/2/?file=73089#file73089line114>
> >
> >     Revert this per guidelines

Will do.


- Diederik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14917
-----------------------------------------------------------


On March 27, 2015, 5:38 p.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 5:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -----
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/b211a53b/attachment-0001.html>