[asterisk-dev] [Code Review] 4544: clang compiler warning: -Wself-assign

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4544/#review14917
-----------------------------------------------------------


I'm wondering if -Wself-assign should not be enabled.  It appears to be just a nuisance warning.


/branches/13/formats/format_wav.c
<https://reviewboard.asterisk.org/r/4544/#comment25538>

    Revert this per guidelines


- rmudgett


On March 27, 2015, 11:38 a.m., Diederik de Groot wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4544/
> -----------------------------------------------------------
> 
> (Updated March 27, 2015, 11:38 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24917
>     https://issues.asterisk.org/jira/browse/ASTERISK-24917
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> clang's static analyzer will throw quite a number warnings / errors during compilation, some of which can be very helpfull in finding corner-case bugs. clang compiler warning:-Wself-assign
> 
> 
> Diffs
> -----
> 
>   /branches/13/formats/format_wav_gsm.c 433444 
>   /branches/13/formats/format_wav.c 433444 
> 
> Diff: https://reviewboard.asterisk.org/r/4544/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Diederik de Groot
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150327/65fe8596/attachment.html>