[asterisk-dev] [Code Review] 4518: testsuite: Add PJSIP test for new rpid_immediate option.

[rmudgett]

> On March 20, 2015, 11:54 p.m., Corey Farrell wrote:
> > Is a sipp scenario needed to verify Asterisk sends the correct SIP packets for rpid_immediate on and off?
> 
> rmudgett wrote:
>     A sipp scenario is not needed.  The test is to check *when* connected line is passed not how since that is what the rpid_immediate option controls.
> 
> Corey Farrell wrote:
>     From r4473 Testing Done:
>     * Made a call chain as follows: 100 -> * -> * -> * -> 200.  With the patch
>     there are no unnecessary messages.  Without the patch there were several
>     "180 Ringing" messages sent back to the caller.
>     
>     This is what I was asking about, if sipp is the caller it will get a different number of SIP messages depending on rpid_immediate.

True, but redundant messages are not a real problem.  It is connected line updates that don't carry party information from the far end that can be a problem.  Connected line updates back to the caller before the call is answered should not be sufficient reason to send a message but gareth thinks it is.


- rmudgett


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14762
-----------------------------------------------------------


On March 23, 2015, 12:21 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4518/
> -----------------------------------------------------------
> 
> (Updated March 23, 2015, 12:21 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24781
>     https://issues.asterisk.org/jira/browse/ASTERISK-24781
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test the rpid_immediate option when enabled and disabled.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 6547 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4518/diff/
> 
> 
> Testing
> -------
> 
> This is the testsuite test to test the rpid_immediate option added by review:
> https://reviewboard.asterisk.org/r/4473/
> 
> The test passes.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150323/60364081/attachment.html>