[asterisk-dev] [Code Review] 4518: testsuite: Add PJSIP test for new rpid_immediate option.

Matt Jordan reviewboard at asterisk.org
Sun Mar 22 23:05:56 CDT 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4518/#review14763
-----------------------------------------------------------



/asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf
<https://reviewboard.asterisk.org/r/4518/#comment25349>

    Is there actually a risk of alice not answering?



/asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/4518/#comment25346>

    I'd only use a single line to break up sections



/asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/4518/#comment25345>

    Remove the extraneous line



/asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/4518/#comment25347>

    Remove commented out sections



/asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf
<https://reviewboard.asterisk.org/r/4518/#comment25348>

    Remove commented out sections


- Matt Jordan


On March 20, 2015, 3:48 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4518/
> -----------------------------------------------------------
> 
> (Updated March 20, 2015, 3:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24781
>     https://issues.asterisk.org/jira/browse/ASTERISK-24781
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> Test the rpid_immediate option when enabled and disabled.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/tests.yaml 6539 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/rpid_immediate/configs/ast1/extensions.conf PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/4518/diff/
> 
> 
> Testing
> -------
> 
> This is the testsuite test to test the rpid_immediate option added by review:
> https://reviewboard.asterisk.org/r/4473/
> 
> The test passes.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150323/8d99b0a6/attachment.html>


More information about the asterisk-dev mailing list