[asterisk-dev] [Code Review] 4497: logger: init_logger_chain has unreachable code

[Corey Farrell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4497/
-----------------------------------------------------------

(Updated March 19, 2015, 5:19 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 433122


Bugs: ASTERISK-24817
    https://issues.asterisk.org/jira/browse/ASTERISK-24817


Repository: Asterisk


Description
-------

init_logger_chain has a block of code to set a default console logger if logger.conf was invalid or not found.  Since the code is unreachable, no logger channels to be created.  This changes it so the default console logger is applied any time logger.conf load fails.


Diffs
-----

  /branches/11/main/logger.c 432991 

Diff: https://reviewboard.asterisk.org/r/4497/diff/


Testing
-------

Verified that nothing was logged to console with missing logger.conf, and that this patch caused console logging to be enabled in that case.  Also verified that valid logger.conf was not effected.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150319/c794af97/attachment-0001.html>