[asterisk-dev] [Code Review] 4497: logger: init_logger_chain has unreachable code

[Scott Griepentrog]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4497/#review14725
-----------------------------------------------------------

Ship it!


Ship It!

- Scott Griepentrog


On March 14, 2015, 4:26 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4497/
> -----------------------------------------------------------
> 
> (Updated March 14, 2015, 4:26 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24817
>     https://issues.asterisk.org/jira/browse/ASTERISK-24817
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> init_logger_chain has a block of code to set a default console logger if logger.conf was invalid or not found.  Since the code is unreachable, no logger channels to be created.  This changes it so the default console logger is applied any time logger.conf load fails.
> 
> 
> Diffs
> -----
> 
>   /branches/11/main/logger.c 432991 
> 
> Diff: https://reviewboard.asterisk.org/r/4497/diff/
> 
> 
> Testing
> -------
> 
> Verified that nothing was logged to console with missing logger.conf, and that this patch caused console logging to be enabled in that case.  Also verified that valid logger.conf was not effected.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150317/aedcf44c/attachment.html>