[asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

[yaron nahum]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4438/
-----------------------------------------------------------

(Updated March 9, 2015, 2:12 p.m.)


Review request for Asterisk Developers.


Changes
-------

According to Joshua's remarks I made some changes in the following places:
- res_pjsip_sdp_rtp.c - get_codecs:
  Set rtp dtmf mode to AST_RTP_DTMF_MODE_INBAND only if the endpoint dtmf mode is AUTO.
- res_pjsip_sdp_rtp.c - set_caps:
  If the rtp dtmf mode is AST_RTP_DTMF_MODE_RFC_2833 deactivate dsp if it is activated.
- dsp.c / dsp.h - 
  Added ast_dsp_get_features function required for the above functionality in order to retrieve current dsp features and deactivate dsp only if no   other feature is activated.


Bugs: ASTERISK-24706
    https://issues.asterisk.org/jira/browse/ASTERISK-24706


Repository: Asterisk


Description
-------

add auto-dtmf mode for pjsip


Diffs (updated)
-----

  /trunk/res/res_pjsip_session.c 431537 
  /trunk/res/res_pjsip_sdp_rtp.c 431537 
  /trunk/res/res_pjsip/pjsip_configuration.c 431537 
  /trunk/res/res_pjsip.c 431537 
  /trunk/main/dsp.c 431537 
  /trunk/include/asterisk/res_pjsip.h 431537 
  /trunk/include/asterisk/dsp.h 431537 
  /trunk/channels/chan_pjsip.c 431537 

Diff: https://reviewboard.asterisk.org/r/4438/diff/


Testing
-------


Thanks,

yaron nahum

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150309/36d49b99/attachment.html>