[asterisk-dev] [Code Review] 4461: app_voicemail: Fix compile breaking in app_voicemail with IMAP_STORAGE.

wdoekes reviewboard at asterisk.org
Fri Mar 6 01:43:16 CST 2015



> On March 4, 2015, 10:22 p.m., rmudgett wrote:
> > Wow.  That assert just appeared out of thin air.

Indeed it does. I claim full responsibility, and have no idea what it did in that function.

I don't even see where I meant to put it in the first place :-O


- wdoekes


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4461/#review14594
-----------------------------------------------------------


On March 5, 2015, 4:35 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4461/
> -----------------------------------------------------------
> 
> (Updated March 5, 2015, 4:35 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is a leftover "assert" in app_voicemail/__messagecount that references variable that don't exist.  This causes the compile to fail when --enable-dev-mode and IMAP_STORAGE are selected.
> 
> This patch removes the assert.
> 
> Will be applied to 11, 13, trunk.
> 
> 
> Diffs
> -----
> 
>   branches/11/apps/app_voicemail.c 432475 
> 
> Diff: https://reviewboard.asterisk.org/r/4461/diff/
> 
> 
> Testing
> -------
> 
> Compiled before and after with and without --enable-dev-mode.  Now compiles correctly with --enable-dev-mode and IMAP_STORAGE.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150306/fa745b89/attachment.html>


More information about the asterisk-dev mailing list