[asterisk-dev] [Code Review] 4461: app_voicemail: Fix compile breaking in app_voicemail with IMAP_STORAGE.

rmudgett reviewboard at asterisk.org
Wed Mar 4 16:22:57 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4461/#review14594
-----------------------------------------------------------

Ship it!


Wow.  That assert just appeared out of thin air.

- rmudgett


On March 4, 2015, 4:10 p.m., George Joseph wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4461/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 4:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is a leftover "assert" in app_voicemail/__messagecount that references variable that don't exist.  This causes the compile to fail when --enable-dev-mode and IMAP_STORAGE are selected.
> 
> This patch removes the assert.
> 
> Will be applied to 11, 13, trunk.
> 
> 
> Diffs
> -----
> 
>   branches/11/apps/app_voicemail.c 432475 
> 
> Diff: https://reviewboard.asterisk.org/r/4461/diff/
> 
> 
> Testing
> -------
> 
> Compiled before and after with and without --enable-dev-mode.  Now compiles correctly with --enable-dev-mode and IMAP_STORAGE.
> 
> 
> Thanks,
> 
> George Joseph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150304/f520507b/attachment-0001.html>


More information about the asterisk-dev mailing list