[asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests

[jbigelow]

> On March 3, 2015, 3:40 p.m., Mark Michelson wrote:
> > /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test, line 291
> > <https://reviewboard.asterisk.org/r/4452/diff/1/?file=71670#file71670line291>
> >
> >     Why "or 0" ? Isn't that a no-op?

Good question. I used 'tests/rest_api/channels/redirect/nominal/run-test' as a base and I'm not sure why myself. I've removed it though.


- jbigelow


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4452/#review14583
-----------------------------------------------------------


On March 4, 2015, 12:58 p.m., jbigelow wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4452/
> -----------------------------------------------------------
> 
> (Updated March 4, 2015, 12:58 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24586
>     https://issues.asterisk.org/jira/browse/ASTERISK-24586
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do.
> 
> Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. :
> * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls.
> * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan.
> * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB.
> * originate_to_stasis_app/local_channels
> 
> Note:  The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. 
> 
> The following test has been modified to ensure no ARI events are received:
> * tests/rest_api/channels/originate_to_dialplan
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 
>   /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 
>   /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475 
> 
> Diff: https://reviewboard.asterisk.org/r/4452/diff/
> 
> 
> Testing
> -------
> 
> * Executed each test successfully 30+ times.
> * Changed the code to force a failure to ensure tests properly failed.
> * Review logs to ensure operation is as expected.
> 
> 
> Thanks,
> 
> jbigelow
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150304/2d949e1a/attachment-0001.html>