[asterisk-dev] [Code Review] 4454: chan_sip: Fix realtime locking inversion when poking a just built peer.

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4454/#review14584
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On Feb. 27, 2015, 11:38 p.m., rmudgett wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4454/
> -----------------------------------------------------------
> 
> (Updated Feb. 27, 2015, 11:38 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24838
>     https://issues.asterisk.org/jira/browse/ASTERISK-24838
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When a realtime peer is built it can cause a locking inversion when the
> just built peer is poked.  If the CLI command "sip show channels" is
> periodically executed a deadlock can happen because of the locking
> inversion.
> 
> * Push the peer poke off onto the scheduler thread to avoid the locking
> inversion of the just built realtime peer.
> 
> 
> Diffs
> -----
> 
>   /branches/11/channels/chan_sip.c 432422 
> 
> Diff: https://reviewboard.asterisk.org/r/4454/diff/
> 
> 
> Testing
> -------
> 
> Compiling and code inspection.  I don't have a realtime setup to test with.
> 
> 
> Thanks,
> 
> rmudgett
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150303/6598b0d4/attachment.html>