[asterisk-dev] Fwd: Code Review request of func_redis module

[Ludovic Gasc]

Hi Sergio,

I've added in my professional schedule to test your module this summer.
I'll open issue or pull request for specific remarks.
However, one of first thing I'll need quickly, is to push any command to
redis, like with kamailio module:
http://kamailio.org/docs/modules/4.4.x/modules/ndb_redis.html#idp206176

Do you see any drawbacks if I add a new function to do that in func_redis ?

My idea is to use PUBLISH command to push only informations I need to my
daemons, instead of to parse lot of messages via AMI, to be more efficient
at high level of calls: http://redis.io/commands/publish

Regards.

--
Ludovic Gasc (GMLudo)
http://www.gmludo.eu/

2015-05-13 12:38 GMT+02:00 Sergio Medina Toledo <gestoip at ull.edu.es>:

> Great, then there isn't any problem, for me is fantastic having a tester
> that can report bugs.
>
> 2015-05-12 20:38 GMT+01:00 Ludovic Gasc <gmludo at gmail.com>:
>
>> Don't worry, I understand it isn't production ready, I'll test that only
>> on a dev instance.
>> I don't know yet if I'll have skills to help you with pull requests, but
>> at least, with tests and eventual bug reports.
>>
>> For now, it isn't really critical, because I've a daemon that plays as a
>> Redis proxy for Asterisk, but I vote always for simplifications, if only I
>> don't have efficiency impacts.
>>
>> --
>> Ludovic Gasc (GMLudo)
>> http://www.gmludo.eu/
>>
>> 2015-05-12 9:04 GMT+02:00 Sergio Medina Toledo <gestoip at ull.edu.es>:
>>
>>> The part of the internal API that I used haven't changed from 11 to 13
>>> so it should work without any problem. But I haven't tested the module
>>> intensively and I'm not sure if it is thread safe, so I don't recommend use
>>> it in production servers right now. Today I'm gonna install the module in
>>> an asterisk 11 active-passive cluster of preproduction to test it better,
>>> after that I will expose my conclusions here, if some one that have more
>>> experience developing in asterisk can look at the code and confirm that it
>>> is thread safe i will be very grateful.
>>>
>>> 2015-05-11 21:22 GMT+01:00 Ludovic Gasc <gmludo at gmail.com>:
>>>
>>>> Hi,
>>>>
>>>> Your library is very interesting, because we already use Redis as a
>>>> cache for some stuffs.
>>>> For now, I've made a FastAGI server to serve Redis data, but it should
>>>> be faster to read Redis data directly.
>>>>
>>>> Do you think I could test your module on an Asterisk 13, or the
>>>> Asterisk internal API is too different to be used with another version than
>>>> 11 ?
>>>>
>>>> Regards.
>>>>
>>>> Ludovic Gasc (GMLudo)
>>>> http://www.gmludo.eu/
>>>> On 11 May 2015 09:14, "GESTION DE TELEFONIA IP" <gestoip at ull.edu.es>
>>>> wrote:
>>>>
>>>>> Hi all, I have developed an asterisk module to interact with redis
>>>>> from the dialplan, the project is motivated by the need to share
>>>>> information between different asterisk in both active-active and
>>>>> active-passive scheme, in an easy way like AstDB. You can use an agi
>>>>> script or a system call to a script to use redis from the dialplan but the
>>>>> performance is low compared to a asterisk module and the integration is
>>>>> worst. I think that maybe this module can be interesting to the
>>>>> community,
>>>>>
>>>>> It's the first time that I develop a asterisk module so If some one
>>>>> can make a code review to the module to see if there are use of insecure
>>>>> functions or something that can crash asterisk, I will be very grateful,
>>>>> the module is under GPLv2 License in this repo
>>>>> https://github.com/tic-ull/func_redis. At the moment the module is
>>>>> shipped outside the asterisk project, as a Cmake project. You can see
>>>>> the instructions to install and to use it in the README.md of the repo.
>>>>>
>>>>> The english isn't my native language so sorry if there ara some
>>>>> writing mistakes.
>>>>>
>>>>>
>>>>> --
>>>>> _____________________________________________________________________
>>>>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>>>>
>>>>> asterisk-dev mailing list
>>>>> To UNSUBSCRIBE or update options visit:
>>>>>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>>>>>
>>>>
>>>> --
>>>> _____________________________________________________________________
>>>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>>>
>>>> asterisk-dev mailing list
>>>> To UNSUBSCRIBE or update options visit:
>>>>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>>>>
>>>
>>>
>>> --
>>> _____________________________________________________________________
>>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>>
>>> asterisk-dev mailing list
>>> To UNSUBSCRIBE or update options visit:
>>>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>>>
>>
>>
>> --
>> _____________________________________________________________________
>> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>>
>> asterisk-dev mailing list
>> To UNSUBSCRIBE or update options visit:
>>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>>
>
>
> --
> _____________________________________________________________________
> -- Bandwidth and Colocation Provided by http://www.api-digital.com --
>
> asterisk-dev mailing list
> To UNSUBSCRIBE or update options visit:
>    http://lists.digium.com/mailman/listinfo/asterisk-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150708/0fd0336a/attachment.html>