[asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4375/
-----------------------------------------------------------

(Updated Jan. 27, 2015, 5:47 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 431114


Repository: Asterisk


Description
-------

There is currently a race condition when unloading the res_parking module. Depending on the will of the universe the subscription invocation may occur AFTER the module is unloaded. This is because the module does NOT use stasis_unsubscribe_and_join when terminating the subscription. It merely uses stasis_unsubscribe.

This change makes it use stasis_unsubscribe_and_join which is documented for usage in this exact scenario.


Diffs
-----

  /branches/13/res/parking/parking_manager.c 431112 

Diff: https://reviewboard.asterisk.org/r/4375/diff/


Testing
-------

Unloaded module a few times, it unloaded.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150127/069ca2c2/attachment.html>