[asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4375/#review14286
-----------------------------------------------------------

Ship it!


Ship It!

- Matt Jordan


On Jan. 26, 2015, 2:07 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4375/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2015, 2:07 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> There is currently a race condition when unloading the res_parking module. Depending on the will of the universe the subscription invocation may occur AFTER the module is unloaded. This is because the module does NOT use stasis_unsubscribe_and_join when terminating the subscription. It merely uses stasis_unsubscribe.
> 
> This change makes it use stasis_unsubscribe_and_join which is documented for usage in this exact scenario.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/parking/parking_manager.c 431112 
> 
> Diff: https://reviewboard.asterisk.org/r/4375/diff/
> 
> 
> Testing
> -------
> 
> Unloaded module a few times, it unloaded.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150126/9ff06858/attachment.html>