[asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process
Joshua Colp
reviewboard at asterisk.org
Thu Jan 15 05:49:43 CST 2015
> On Jan. 15, 2015, 8:43 a.m., Olle E Johansson wrote:
> > You write that SRV is done if the URI is not IP. Check that SRV is not done if there's any port in the URI. If there's a port in the URI, the hostname is to be used for A/AAAA lookups. If there's no port, go for NAPTR, then SRV.
> >
> > As a side note, SRV may change your port address.
I've tweaked the page slightly to include this condition but have not gone further. Specifically because this page is for how a local transport is selected based on the existing code and not the process of target resolution itself. I mentioned target resolution slightly because of the requirement of a "transport" parameter. If DNS work occurs I fully expect another wiki page to be created describing how it works within PJSIP right now, its shortcomings, and ways to overcome them.
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4328/#review14194
-----------------------------------------------------------
On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4328/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2015, 1:33 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> The transport selection process of PJSIP (and by extension some of our own logic) can be a dark dark thing. To help illuminate what happens I have created a wiki page[1] which goes through (based on the message type) the process by which a transport is chosen and how it can potentially change.
>
> Stuff to look at:
> 1. Is this detailed enough?
> 2. Can you follow it? If not, how could it be made clearer?
> 3. Are there additional common issues that should be covered?
>
> [1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection
>
>
> Diffs
> -----
>
>
> Diff: https://reviewboard.asterisk.org/r/4328/diff/
>
>
> Testing
> -------
>
> I opened the wiki page. It opened.
>
>
> Thanks,
>
> Joshua Colp
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150115/eb3414cc/attachment.html>
More information about the asterisk-dev
mailing list