[asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

Olle E Johansson reviewboard at asterisk.org
Thu Jan 15 02:43:24 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4328/#review14194
-----------------------------------------------------------


You write that SRV is done if the URI is not IP. Check that SRV is not done if there's any port in the URI. If there's a port in the URI, the hostname is to be used for A/AAAA lookups. If there's no port, go for NAPTR, then SRV.

As a side note, SRV may change your port address.

- Olle E Johansson


On Jan. 12, 2015, 2:33 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4328/
> -----------------------------------------------------------
> 
> (Updated Jan. 12, 2015, 2:33 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The transport selection process of PJSIP (and by extension some of our own logic) can be a dark dark thing. To help illuminate what happens I have created a wiki page[1] which goes through (based on the message type) the process by which a transport is chosen and how it can potentially change.
> 
> Stuff to look at:
> 1. Is this detailed enough?
> 2. Can you follow it? If not, how could it be made clearer?
> 3. Are there additional common issues that should be covered?
> 
> [1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection
> 
> 
> Diffs
> -----
> 
> 
> Diff: https://reviewboard.asterisk.org/r/4328/diff/
> 
> 
> Testing
> -------
> 
> I opened the wiki page. It opened.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150115/e071787a/attachment.html>


More information about the asterisk-dev mailing list