[asterisk-dev] [Code Review] 4317: Testsuite: PJSIP remote attended transfer test
Mark Michelson
reviewboard at asterisk.org
Mon Jan 12 17:16:04 CST 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4317/
-----------------------------------------------------------
(Updated Jan. 12, 2015, 11:16 p.m.)
Review request for Asterisk Developers.
Changes
-------
Removed extra debugging message I left in pjsua_mod.py
Repository: testsuite
Description
-------
This is a testsuite test that performs a remote attended transfer. The test is a bit odd, but the test-config.yaml should do a decent job of explaining how this works.
The test could be structured into a more strict state machine style, but given that this is just a test, I didn't want to waste extra cycles on that. As it is, the test passes, and the comments should do a decent job of explaining what's going on.
The setup is a bit contrived, but it accurately tests a remote attended transfer scenario, so it works :)
Diffs (updated)
-----
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/tests.yaml 6226
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/transfer.py PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/test-config.yaml PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast2/pjsip.conf PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast2/extensions.conf PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast1/pjsip.conf PRE-CREATION
/asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast1/extensions.conf PRE-CREATION
/asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6226
Diff: https://reviewboard.asterisk.org/r/4317/diff/
Testing
-------
The test passes with the patch from /r/4296. Without that patch, the test fails.
Thanks,
Mark Michelson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150112/6ae84cbd/attachment.html>
More information about the asterisk-dev
mailing list