[asterisk-dev] [Code Review] 4317: Testsuite: PJSIP remote attended transfer test

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4317/#review14137
-----------------------------------------------------------



/asterisk/trunk/lib/python/asterisk/pjsua_mod.py
<https://reviewboard.asterisk.org/r/4317/#comment24627>

    This message seems a little odd and could perhaps use rewording as it leaves the reader guessing.


- Kevin Harwell


On Jan. 6, 2015, 6:16 p.m., Mark Michelson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4317/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2015, 6:16 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This is a testsuite test that performs a remote attended transfer. The test is a bit odd, but the test-config.yaml should do a decent job of explaining how this works.
> 
> The test could be structured into a more strict state machine style, but given that this is just a test, I didn't want to waste extra cycles on that. As it is, the test passes, and the comments should do a decent job of explaining what's going on.
> 
> The setup is a bit contrived, but it accurately tests a remote attended transfer scenario, so it works :)
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/tests.yaml 6177 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/transfer.py PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/pjsip/transfers/attended_transfer/nominal/callee_remote/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6177 
> 
> Diff: https://reviewboard.asterisk.org/r/4317/diff/
> 
> 
> Testing
> -------
> 
> The test passes with the patch from /r/4296. Without that patch, the test fails.
> 
> 
> Thanks,
> 
> Mark Michelson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150109/1e9fa231/attachment.html>