[asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

Corey Farrell reviewboard at asterisk.org
Fri Feb 20 20:51:46 CST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4435/
-----------------------------------------------------------

(Updated Feb. 20, 2015, 8:51 p.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 432057


Bugs: ASTERISK-24813
    https://issues.asterisk.org/jira/browse/ASTERISK-24813


Repository: Asterisk


Description
-------

listener() opens the same code block in two places (#if and #else).  This confuses some folding editors causing it to think that an extra code block was opened.  Folding in 'geany' causes all code after listener() to be folded as if it were part of that procedure.

This patch does not change any compiled logic, it just makes it easier for some editors to parse.


Diffs
-----

  /trunk/main/asterisk.c 431991 

Diff: https://reviewboard.asterisk.org/r/4435/diff/


Testing
-------

Some testsuite runs.


Thanks,

Corey Farrell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150221/ea55a0a5/attachment.html>


More information about the asterisk-dev mailing list