[asterisk-dev] [Code Review] 4435: Reverse #if statement in asterisk.c to fix code folding

[Corey Farrell]

> On Feb. 19, 2015, 5:26 p.m., rmudgett wrote:
> > /trunk/main/asterisk.c, line 1613
> > <https://reviewboard.asterisk.org/r/4435/diff/1/?file=71478#file71478line1613>
> >
> >     I prefer the
> >     
> >     #if defined(SO_PASSCRED)
> >     
> >     format as it allows more complicated expressions.

Will switch this when I commit.


- Corey


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4435/#review14494
-----------------------------------------------------------


On Feb. 19, 2015, 4:43 p.m., Corey Farrell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4435/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2015, 4:43 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24813
>     https://issues.asterisk.org/jira/browse/ASTERISK-24813
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> listener() opens the same code block in two places (#if and #else).  This confuses some folding editors causing it to think that an extra code block was opened.  Folding in 'geany' causes all code after listener() to be folded as if it were part of that procedure.
> 
> This patch does not change any compiled logic, it just makes it easier for some editors to parse.
> 
> 
> Diffs
> -----
> 
>   /trunk/main/asterisk.c 431991 
> 
> Diff: https://reviewboard.asterisk.org/r/4435/diff/
> 
> 
> Testing
> -------
> 
> Some testsuite runs.
> 
> 
> Thanks,
> 
> Corey Farrell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150219/63034f19/attachment-0001.html>