[asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4429/#review14479
-----------------------------------------------------------

Ship it!


Looks fine to me.  Minor nit.


branches/11/bridges/bridge_softmix.c
<https://reviewboard.asterisk.org/r/4429/#comment25017>

    Assigning entry here is unnecessary.
    The value set in entry here is not used.


- rmudgett


On Feb. 16, 2015, 12:30 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4429/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2015, 12:30 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24797
>     https://issues.asterisk.org/jira/browse/ASTERISK-24797
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> When more than one call using the same codec type enters into a softmix bridge and no audio is present for a channel the bridge optimizes the out frame by using the same one for all channels with the same codec type. Unfortunately, when that number (channels with same codec type) dropped to <= 1 the codec was not dereferenced. At least not until all parties left the bridge. Thus in the case of G.729 the license was not released. This patch ensures that the codec is dereferenced immediately when the optimization no longer applies.
> 
> 
> Diffs
> -----
> 
>   branches/11/bridges/bridge_softmix.c 431876 
> 
> Diff: https://reviewboard.asterisk.org/r/4429/diff/
> 
> 
> Testing
> -------
> 
> Created a 3 party confbridge. Two channels were using g.729 and the other using ulaw. Hung up both the channels using g.729 and noted that the confbridge was still holding a reference to a g.729 license. After applying the patch noted that it no longer held onto the license.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150217/02eaaf7d/attachment.html>