[asterisk-dev] [Code Review] 4418: SDES-SRTP: Handle SRTP keys negotiated with key lifetime/MKI (oej branch lingon-srtp-key-lifetime-1.8) - Asterisk 13

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4418/
-----------------------------------------------------------

Review request for Asterisk Developers and Olle E Johansson.


Bugs: ASTERISK-17721, ASTERISK-17899 and ASTERISK-22748
    https://issues.asterisk.org/jira/browse/ASTERISK-17721
    https://issues.asterisk.org/jira/browse/ASTERISK-17899
    https://issues.asterisk.org/jira/browse/ASTERISK-22748


Repository: Asterisk


Description
-------

Note that this patch is a forward port of oej's lingon-srtp-key-lifetime-1.8 branch, with a few small modifications to reduce block indentation and a few improvements made to surrounding existing code.

This patch is for Asterisk 13, and is essentially identical to https://reviewboard.asterisk.org/r/4419 - save for a few small modifications for the public API written when the code was ported into the core. As such, this patch should only be reviewed for those changes that are not in r4419.


Diffs
-----

  /branches/13/main/sdp_srtp.c 431750 

Diff: https://reviewboard.asterisk.org/r/4418/diff/


Testing
-------

Tests were added for chan_sip and updated for chan_pjsip - see https://reviewboard.asterisk.org/r/4420 . This includes both nominal and off-nominal offers negotiating SDES-SRTP.


Thanks,

Matt Jordan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150214/410ee162/attachment.html>