[asterisk-dev] Team branches and gerrit

Russell Bryant russell at russellbryant.net
Fri Apr 24 08:42:07 CDT 2015


On Fri, Apr 24, 2015 at 8:31 AM, Joshua Colp <jcolp at digium.com> wrote:

> Olle E. Johansson wrote:
>
>> Playing around following Matt's wiki page on gerrit usage, I created
>> a team branch and did two commits. When pushing it with "git review
>> {branch}" only the last commit shows up.
>>
>> Is that the way it's supposed to be? I thought the whole branch was
>> the review subject, not just a single commit.
>>
>
> Gerrit works on a single commit (what it refers to as a patch set) that
> you want included into a specific branch. As a result you need to squash
> all commits into a single one, and if review feedback warrants further
> changes they also need to be squashed back into a single commit with the
> original changes. The single commit you post for review is what is reviewed
> and merged into the branch.
>

Gerrit can also work on a patch series, and tracks dependencies between
those patches.

-- 
Russell Bryant
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150424/114f05de/attachment.html>


More information about the asterisk-dev mailing list