[asterisk-dev] Team branches and gerrit

[Joshua Colp]

Olle E. Johansson wrote:
> Playing around following Matt's wiki page on gerrit usage, I created
> a team branch and did two commits. When pushing it with "git review
> {branch}" only the last commit shows up.
>
> Is that the way it's supposed to be? I thought the whole branch was
> the review subject, not just a single commit.

Gerrit works on a single commit (what it refers to as a patch set) that 
you want included into a specific branch. As a result you need to squash 
all commits into a single one, and if review feedback warrants further 
changes they also need to be squashed back into a single commit with the 
original changes. The single commit you post for review is what is 
reviewed and merged into the branch.

Cheers,

-- 
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org