[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

[Matt Jordan (Code Review)]

Matt Jordan has posted comments on this change.

Change subject: git migration: Remove support for file versions
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:

Line 390: 	return NULL;
> Sorry I didn't think of this in the review for 13, maybe we should check fo
If we did that, we'd have to keep the version field on the struct, and we'd have to go ahead and populate that version field with what is passed by the the ASTERISK_FILE_VERSION macro. That results in one of two scenarios:
1) We return "$Revision$" for all files in the source tree
2) We explicitly add a check in this function to see if the string in the version field is "$Revision$", and if it is, return a blank or NULL value.

Neither feel quite worth it. If someone was using the function, then the return value is still allowed by the function (it just always returns it) - ostensibly, they should be handling a NULL return value. Given that the general consensus was that this wasn't a feature worth preserving, I think it's okay to punt on the case where an external module used this function.

Of course, I'll probably be back a month or two later with a mea culpa... :-)


-- 
To view, visit https://gerrit.asterisk.org/61
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia932d3c64cd18a14a3c894109baa657ec0a85d28
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes