[asterisk-dev] Change in asterisk[11]: git migration: Remove support for file versions

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: git migration: Remove support for file versions
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

So I'm a bit indifferent about the finding against main/asterisk.c, up to you if you want to address or not.  Please keep the functionality for 11 and 13 the same if you do address it.

https://gerrit.asterisk.org/#/c/61/1/main/asterisk.c
File main/asterisk.c:

Line 390: 	return NULL;
Sorry I didn't think of this in the review for 13, maybe we should check for the file, return the Asterisk version if found.  If not found then return NULL.

This way if something uses this to check that a source is registered it will return NULL or not NULL the same as before.

On the other hand I'm not sure how useful this is, just thinking of edge cases where this could break compatibility.


-- 
To view, visit https://gerrit.asterisk.org/61
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia932d3c64cd18a14a3c894109baa657ec0a85d28
Gerrit-PatchSet: 1
Gerrit-Project: asterisk
Gerrit-Branch: 11
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-HasComments: Yes