[asterisk-dev] Change in asterisk[master]: git migration: Refactor the ASTERISK_FILE_VERSION macro

[Corey Farrell (Code Review)]

Corey Farrell has posted comments on this change.

Change subject: git migration: Refactor the ASTERISK_FILE_VERSION macro
......................................................................


Patch Set 3: Code-Review-1

(9 comments)

https://gerrit.asterisk.org/#/c/54/3//COMMIT_MSG
Commit Message:

Line 22: Other facilities other
Remove one of the other's.


https://gerrit.asterisk.org/#/c/54/3/include/asterisk.h
File include/asterisk.h:

Line 164: void ast_register_file(const char *file);
Given that this is meant for use through a macro only, shouldn't it be __ast_register_file?  Ditto for ast_unregister_file.


Line 203:  * ASTERISK_REGISTER_FILE(__FILE__, "\$Revision\$")
Update parameters.


Line 206: * \note The dollar signs above have been protected with backslashes to keep
        :  * SVN from modifying them in this file; under normal circumstances they would
        :  * not be present and SVN would expand the Revision keyword into the file's
        :  * revision number.
No longer applies.


Line 213: #define ASTERISK_REGISTER_FILE(file) \
Couldn't we drop the 'file' parameter too, just use __FILE__ inside the macro?


https://gerrit.asterisk.org/#/c/54/3/main/manager.c
File main/manager.c:

Line 5998: 	snprintf(cut, (sizeof(filename) - strlen(filename)) - 1, ".c");
         : 	ast_debug(1, "**** ModuleCheck .c file %s\n", filename);
Since we're no longer checking the source file registration I think this should be removed.  Also it's the wrong filename for C++ modules (like chan_vpb.cc).


https://gerrit.asterisk.org/#/c/54/3/utils/check_expr.c
File utils/check_expr.c:

Line 155: //void ast_register_file(const char *file, const char *version);
        : //void ast_unregister_file(const char *file);
Delete..


Line 164: void ast_register_file(const char *file, const char *version);  
Tailing whitespace


Line 167: int ast_add_profile(const char *x, uint64_t scale) { return 0;} 
Tailing whitespace


-- 
To view, visit https://gerrit.asterisk.org/54
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id146f24e9d968dccd64cb09dbfa1da3d9ac719f6
Gerrit-PatchSet: 3
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Owner: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-HasComments: Yes