[asterisk-dev] [Code Review] 4589: res_pjsip_t38: Add missing initialization of udptl->far_max_datagram in t38_initialize_session()

[Juergen Spies]

> On April 6, 2015, 1:24 p.m., Joshua Colp wrote:
> > I think the t38_interpret_sdp function should be updated to only set the far max datagram if not explicitly configured. Right now it will set it again needlessly.

That is true if we can be sure that t38_initialize_session() has always been called before t38_interpret_sdp().
As far as I have seen, t38_interpret_sdp() is called from two locations:
1. defer_incoming_sdp_stream(): There this is clearly the case,
2. apply_negotiated_sdp_stream(): As far as I have seen it is called via a pointer to function from
   handle_negotiated_sdp_session_media(). Due to my limited knowledge of the inner dynamics of pjsip I was not able to
   ensure that t38_initialize_session() has really been called before.
Because of that I am not comfortable to remove this potentially redundant call from t38_interpret_sdp().
I would appreciate if someone w/ more experience with pjsip could look into this.


- Juergen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4589/#review15066
-----------------------------------------------------------


On April 3, 2015, 10:10 p.m., Juergen Spies wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4589/
> -----------------------------------------------------------
> 
> (Updated April 3, 2015, 10:10 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24928
>     https://issues.asterisk.org/jira/browse/ASTERISK-24928
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Initialize "udptl->far_max_datagram" in t38_initialize_session() with a default value or a value provided
> in pjsip.conf (t38_udptl_maxdatagram).
> Without this far_max_datagram remains -1 if the remote endpoint does not provide the MediaAttribute T38FaxMaxDatagram
> in it's SIP INVITE SDP. This will result in the INVITE being rejected.
> 
> 
> Diffs
> -----
> 
>   /branches/13/res/res_pjsip_t38.c 433967 
> 
> Diff: https://reviewboard.asterisk.org/r/4589/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Juergen Spies
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20150406/39cc90aa/attachment.html>