<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/4589/">https://reviewboard.asterisk.org/r/4589/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 6th, 2015, 1:24 p.m. UTC, <b>Joshua Colp</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think the t38_interpret_sdp function should be updated to only set the far max datagram if not explicitly configured. Right now it will set it again needlessly.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That is true if we can be sure that t38_initialize_session() has always been called before t38_interpret_sdp().
As far as I have seen, t38_interpret_sdp() is called from two locations:
1. defer_incoming_sdp_stream(): There this is clearly the case,
2. apply_negotiated_sdp_stream(): As far as I have seen it is called via a pointer to function from
handle_negotiated_sdp_session_media(). Due to my limited knowledge of the inner dynamics of pjsip I was not able to
ensure that t38_initialize_session() has really been called before.
Because of that I am not comfortable to remove this potentially redundant call from t38_interpret_sdp().
I would appreciate if someone w/ more experience with pjsip could look into this.</pre>
<br />
<p>- Juergen</p>
<br />
<p>On April 3rd, 2015, 10:10 p.m. UTC, Juergen Spies wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Juergen Spies.</div>
<p style="color: grey;"><i>Updated April 3, 2015, 10:10 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://issues.asterisk.org/jira/browse/ASTERISK-24928">ASTERISK-24928</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
Asterisk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Initialize "udptl->far_max_datagram" in t38_initialize_session() with a default value or a value provided
in pjsip.conf (t38_udptl_maxdatagram).
Without this far_max_datagram remains -1 if the remote endpoint does not provide the MediaAttribute T38FaxMaxDatagram
in it's SIP INVITE SDP. This will result in the INVITE being rejected.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/branches/13/res/res_pjsip_t38.c <span style="color: grey">(433967)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/4589/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>