[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

[Ashley Sanders (Code Review)]

Ashley Sanders has posted comments on this change.

Change subject: Rewrite sip_attended_transfer test to stop failing.
......................................................................


Patch Set 3: Code-Review+1

(2 comments)

Very nice!!! Thanks for taking my (more reasonable) suggestions =D

I wanted to note one more thing. And, since this is more or less going into the proverbial 'bike shed' argument, I am putting this comment here, just as an FYI :)

The 'call' parameter used in the CallCallback init method could be avoided and simply used as a hard-coded value inside the init method's call to its base type's init method (since it is only ever used as the hard-coded value in the two instantiation statements, anyway):
    def __init__(self, on_answered):
        pj.CallCallback.__init__(self, None)
        self.on_answered = on_answered

https://gerrit.asterisk.org/#/c/19/3/tests/channels/SIP/sip_attended_transfer/attended_transfer.py
File tests/channels/SIP/sip_attended_transfer/attended_transfer.py:

Line 36: class CallCallback(pj.CallCallback):
Awesome! Very nice.


Line 55: class BridgeState(object):
Woot! Awesome.


-- 
To view, visit https://gerrit.asterisk.org/19
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1676801d90bcafc28ba25e8b6889f40ab08cc90e
Gerrit-PatchSet: 3
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes