[asterisk-dev] Change in testsuite[master]: Rewrite sip_attended_transfer test to stop failing.

Ashley Sanders (Code Review) asteriskteam at digium.com
Wed Apr 1 23:13:08 CDT 2015


Ashley Sanders has posted comments on this change.

Change subject: Rewrite sip_attended_transfer test to stop failing.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/19/2/tests/channels/SIP/sip_attended_transfer/attended_transfer.py
File tests/channels/SIP/sip_attended_transfer/attended_transfer.py:

Line 121:                 self.call_carol()
> Well spotted! But, this is actually done intentionally. The reason is that 
Good deal. Given your constraints, I think that using this approach is an appropriate choice.

As a footnote - this response applies to the remaining three comments in this file, also :)


-- 
To view, visit https://gerrit.asterisk.org/19
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1676801d90bcafc28ba25e8b6889f40ab08cc90e
Gerrit-PatchSet: 2
Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Owner: Mark Michelson <mmichelson at digium.com>
Gerrit-Reviewer: Ashley Sanders <asanders at digium.com>
Gerrit-Reviewer: Mark Michelson <mmichelson at digium.com>
Gerrit-HasComments: Yes



More information about the asterisk-dev mailing list