[asterisk-dev] [Code Review] 3972: Change DAHDI_UDEV_HOOK_DIR to honor --prefix

[Tzafrir Cohen]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3972/#review13229
-----------------------------------------------------------


Short version: not needed, IMO.

The path was hard-coded in the first place because the DAHDI udev hooks directory is explicitly hard-coded. Placing it elsewhere does nothing. If the prefix is anything other than '/usr'. this hook script is thus simply not copied.

See also Oron Peled's comment on the list: http://lists.digium.com/pipermail/asterisk-dev/2014-September/070114.html

- Tzafrir Cohen


On Sept. 3, 2014, 1:57 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3972/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2014, 1:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> I'm a bit wierd, and I configure asterisk with --prefix=/opt/asterisk,
> so that I can install it without running as root. The install script
> for the DAHDI hook scripts were hard coded to install into /usr/share,
> which foils my weirdness.
> 
> This patch changes the install location for the DAHDI hook scripts to
> honor --prefix. It also moves the variable in the Makefile so that it
> doesn't get between the _MAKEOPTS variables and the comment describing
> them.
> 
> 
> Diffs
> -----
> 
>   /branches/13/Makefile 422556 
> 
> Diff: https://reviewboard.asterisk.org/r/3972/diff/
> 
> 
> Testing
> -------
> 
> Ran ./configure && make all install to verify that the hook script
> installed into /usr/share/dahdi/span_config.d.
> 
> Ran ./configure --prefix=/opt/asterisk && make all install to verify
> that the hook script installed into
> /opt/Asterisk/share/dahdi/span_config.d
> 
> 
> Thanks,
> 
> David Lee
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140904/752897d7/attachment-0001.html>