[asterisk-dev] [Code Review] 3863: testsuite: Add two tests for transmission of RTCP information to a HEP server

[Matt Jordan]

> On Aug. 5, 2014, 4:11 p.m., Scott Griepentrog wrote:
> > I'm getting a random number (4-6) of packets that didn't match.  Tested with a fresh install of trunk with res_hep* enabled, and fresh patched testsuite, on a Centos 6 x86_64.
> 
> Scott Griepentrog wrote:
>     Further details:  Centos 6, 32 & 64 bit, tests rtcp-sender and rtcp-receiver both fail with multiple "Failed to find match for packet" messages.  The other hep tests pass.
> 
> Matt Jordan wrote:
>     That's not enough info to go on :-)
>     
>     I'll try and reproduce it here. It's possible that the filter isn't working as it is supposed to on the PJSIP packets.

The issue was a problem with the regular expression matching for some integer values in rtcp_sender. Several regular expressions were defined as being integers, not strings - as a result, they would never match any value passed to them.

Both tests *should* now pass.


- Matt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3863/#review13009
-----------------------------------------------------------


On July 27, 2014, 10:43 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3863/
> -----------------------------------------------------------
> 
> (Updated July 27, 2014, 10:43 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Repository: testsuite
> 
> 
> Description
> -------
> 
> This patch adds two tests that cover transmitting RTCP information to a HEP server:
>  * rtcp-sender: One Asterisk instance dials another Asterisk instance. Audio is streamed from the first instance and echo'd back from the second to the first. This results in RTCP information from both instances being sent to a HEP server, where both sides are 'senders' and thus generate/receive SR packets.
>  * rtcp-receiver: One Asterisk instance dials another Asterisk instance. Audio is streamed from the first instance and absorbed by the second. This results in RTCP information from both instances being sent to a HEP server, where the first transmits SR packets and received RR packets and the second transmits RR packets and received SR packets.
> 
> The test does basic validation of the received HEP packets from both Asterisk instances.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/hep/tests.yaml 5254 
>   /asterisk/trunk/tests/hep/rtcp-sender/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/hep.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/hep/pjsip/test-config.yaml 5254 
>   /asterisk/trunk/tests/hep/pjsip-ipv6/test-config.yaml 5254 
>   /asterisk/trunk/tests/hep/pjsip-auth/test-config.yaml 5254 
>   /asterisk/trunk/tests/hep/hep_capture_node.py 5254 
>   /asterisk/trunk/lib/python/asterisk/test_suite_utils.py 5254 
>   /asterisk/trunk/lib/python/asterisk/ari.py 5254 
> 
> Diff: https://reviewboard.asterisk.org/r/3863/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt Jordan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20140902/75990088/attachment.html>