<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://reviewboard.asterisk.org/r/3863/">https://reviewboard.asterisk.org/r/3863/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 5th, 2014, 4:11 p.m. CDT, <b>Scott Griepentrog</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm getting a random number (4-6) of packets that didn't match. Tested with a fresh install of trunk with res_hep* enabled, and fresh patched testsuite, on a Centos 6 x86_64.</pre>
</blockquote>
<p>On August 5th, 2014, 4:45 p.m. CDT, <b>Scott Griepentrog</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Further details: Centos 6, 32 & 64 bit, tests rtcp-sender and rtcp-receiver both fail with multiple "Failed to find match for packet" messages. The other hep tests pass.</pre>
</blockquote>
<p>On August 5th, 2014, 4:56 p.m. CDT, <b>Matt Jordan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That's not enough info to go on :-)
I'll try and reproduce it here. It's possible that the filter isn't working as it is supposed to on the PJSIP packets.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The issue was a problem with the regular expression matching for some integer values in rtcp_sender. Several regular expressions were defined as being integers, not strings - as a result, they would never match any value passed to them.
Both tests *should* now pass.</pre>
<br />
<p>- Matt</p>
<br />
<p>On July 27th, 2014, 10:43 a.m. CDT, Matt Jordan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://reviewboard.asterisk.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Asterisk Developers.</div>
<div>By Matt Jordan.</div>
<p style="color: grey;"><i>Updated July 27, 2014, 10:43 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
testsuite
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch adds two tests that cover transmitting RTCP information to a HEP server:
* rtcp-sender: One Asterisk instance dials another Asterisk instance. Audio is streamed from the first instance and echo'd back from the second to the first. This results in RTCP information from both instances being sent to a HEP server, where both sides are 'senders' and thus generate/receive SR packets.
* rtcp-receiver: One Asterisk instance dials another Asterisk instance. Audio is streamed from the first instance and absorbed by the second. This results in RTCP information from both instances being sent to a HEP server, where the first transmits SR packets and received RR packets and the second transmits RR packets and received SR packets.
The test does basic validation of the received HEP packets from both Asterisk instances.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/asterisk/trunk/tests/hep/tests.yaml <span style="color: grey">(5254)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-sender/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/test-config.yaml <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/configs/ast2/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/pjsip.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/hep.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/rtcp-receiver/configs/ast1/extensions.conf <span style="color: grey">(PRE-CREATION)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip/test-config.yaml <span style="color: grey">(5254)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-ipv6/test-config.yaml <span style="color: grey">(5254)</span></li>
<li>/asterisk/trunk/tests/hep/pjsip-auth/test-config.yaml <span style="color: grey">(5254)</span></li>
<li>/asterisk/trunk/tests/hep/hep_capture_node.py <span style="color: grey">(5254)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/test_suite_utils.py <span style="color: grey">(5254)</span></li>
<li>/asterisk/trunk/lib/python/asterisk/ari.py <span style="color: grey">(5254)</span></li>
</ul>
<p><a href="https://reviewboard.asterisk.org/r/3863/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>