[asterisk-dev] [Code Review] 3948: Asterisk does not respect outbound proxy when sending qualify requests

[Damian Ivereigh]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3948/
-----------------------------------------------------------

(Updated Oct. 17, 2014, 8:07 a.m.)


Status
------

This change has been marked as submitted.


Review request for Asterisk Developers.


Changes
-------

Committed in revision 425818


Bugs: ASTERISK-24063
    https://issues.asterisk.org/jira/browse/ASTERISK-24063


Repository: Asterisk


Description
-------

The outboundproxy setting is ignored when sending the qualify packets (OPTIONS). This means that if an asterisk server is unable to send the packet directly to a peer, it is unable to qualify any non inbound registered peer (e.g. a peer SIP Trunk). This problem is found on asterisk-11.6-cert4 (and many others)

It has been pointed out (thanks Walter Doekes), that the p->outboundproxy may not be freed at the end which would create a memory leak.   


Diffs
-----

  certified/tags/11.6-cert4/channels/chan_sip.c 422052 

Diff: https://reviewboard.asterisk.org/r/3948/diff/


Testing
-------

Have run this change in production for many months, however the possible memory leak issue needs to be verified.


Thanks,

Damian Ivereigh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141017/3f8aa5fc/attachment.html>