[asterisk-dev] [Code Review] 3948: Asterisk does not respect outbound proxy when sending qualify requests

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3948/#review13534
-----------------------------------------------------------

Ship it!


Okay!

In the interest of not letting what we are all pretty sure is a bug stagnate, I'll click the Ship It!

If this patch causes a regression (and I seriously hope it doesn't), then I'll involve Damian and we can look again at this particular issue.

In addition, if we find ourselves chasing the bug tracker, we will come back around and discuss - again - how this silly option is supposed to work. In particular, users of this option *SHOULD* write down what Asterisk should do in nominal registration, inbound/outbound calls, subscriptions, qualifies, and the like. That should be sent to the -dev list, so that we can actually figure out the behavior of this thing instead of playing bug whack-a-mole.

And I understand: outbound proxies are normal, and used extensively, and this option is probably enabled all sorts of places. Except that as we've discussed previously, there's a lot of times when you want to respect the outbound proxy for some requests/responses but not for everything. That makes this tricky, and tricky options have a tendency to (a) break and (b) be features in one system and a regression in another.

- Matt Jordan


On Aug. 25, 2014, 5:04 p.m., Damian Ivereigh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/3948/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2014, 5:04 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24063
>     https://issues.asterisk.org/jira/browse/ASTERISK-24063
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> The outboundproxy setting is ignored when sending the qualify packets (OPTIONS). This means that if an asterisk server is unable to send the packet directly to a peer, it is unable to qualify any non inbound registered peer (e.g. a peer SIP Trunk). This problem is found on asterisk-11.6-cert4 (and many others)
> 
> It has been pointed out (thanks Walter Doekes), that the p->outboundproxy may not be freed at the end which would create a memory leak.   
> 
> 
> Diffs
> -----
> 
>   certified/tags/11.6-cert4/channels/chan_sip.c 422052 
> 
> Diff: https://reviewboard.asterisk.org/r/3948/diff/
> 
> 
> Testing
> -------
> 
> Have run this change in production for many months, however the possible memory leak issue needs to be verified.
> 
> 
> Thanks,
> 
> Damian Ivereigh
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141015/465b0af0/attachment.html>