[asterisk-dev] [Code Review] 4050: Add ability for Channel Drivers to provide Presence State information

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4050/#review13510
-----------------------------------------------------------



/trunk/main/presencestate.c
<https://reviewboard.asterisk.org/r/4050/#comment24030>

    So, I'm not sure this is the behaviour that we would want.
    
    If a channel driver provides presence information, then the presence information provided by the channel driver supercedes any custom presence provider. That is:
    
    exten => hint,SIP/alice&CustomPresence:alice
    
    Will *always* use the presence provided by SIP/alice, instead of the custom presence provider. That feels like a loss of functionality.
    
    Prior to this patch, we would only use the presence information provided by a single custom presence provider, since presence information could only come from custom presence providers. If the channel drivers provide that as well, there probably needs to be some mechanism to aggregate that together.


- Matt Jordan


On Oct. 5, 2014, 11:18 p.m., gareth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/4050/
> -----------------------------------------------------------
> 
> (Updated Oct. 5, 2014, 11:18 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-24363
>     https://issues.asterisk.org/jira/browse/ASTERISK-24363
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch adds the ability for channel drivers to supply presence information in a similar manner to device state.
> 
> eg: exten => XXX,hint,,<Technology>/<Resource>
> 
> 
> Diffs
> -----
> 
>   /trunk/main/presencestate.c 424055 
>   /trunk/main/channel.c 424055 
>   /trunk/include/asterisk/channel.h 424055 
> 
> Diff: https://reviewboard.asterisk.org/r/4050/diff/
> 
> 
> Testing
> -------
> 
> Code is originally written as part of ASTERISK-13145 which has undergone extensive testing.
> 
> 
> Thanks,
> 
> gareth
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20141014/1c7b2235/attachment-0001.html>